multiple bugs in Table elements

[arminunruh]

hey thanks! im on holidays, i will take a closer look in like a week

[dafv]

hey @arminunruh, any updates on this?

[arminunruh]

hey im looking into it now

[arminunruh]

ok number 2 i fixed now and will be included with the next update

[arminunruh]

ok number 3:

im not a 100% sure, but i think its because u're using "scroll animation"

the element inside the collapsed row is displaced because of this animation, so the height is calculated wrong.

with the next update, any elements inside a collapsed row will not get this animation.

after the next update you can try if this works correctly then

[arminunruh]

issue 1:

expanding and collapsing rows on desktop layout and phone layout:

expand/collapse is based on the row's ID, not the row's position/index.

each row has an ID.
when you make a link expand/collapse a certain row, then that link remembers the ID of that row. and expands/collapses it based on that ID.

this way, you can move around a row and it will stay the expanded/collapsed row of that link.

when you add rows to the custom phone layout, they may get different Id's than rows in the desktop layout.

so if you just copy over a link that expands a row from the desktop layout to the phone layout or the other way around, it may target a row that doesn't exist.

that is why any texts that contain a expand/collapse row are not synced between desktop and phone layoout when you change the text/link:

all of this means: you may need to set expand and collapse row links for desktop layout and custom phone layout separately

[dafv]

Hey @arminunruh
I think issues 2 and 3 are fixed now, thank you!

Regarding the first issue:

Since all the desktop and mobile layouts have synced elements (with “Sync Element Content”), when I change the Expand/Collapse Row Links on mobile, it creates issues on desktop and vice versa. So it’s basically creating problems that the user doesn’t expect and can miss.

I understand the row ID process method, but maybe, for lack of a better one in this context, it would be more user-friendly to automatically remove the Expand/Collapse links on synced elements (of the later added layout). That way, it wouldn’t create subsequent issues on the first layout, and we would still be able to keep the text synced between layouts (we would just need to add the expand/collapse links manually on each layout).

Also, where’s that “Not syncing text” warning? I didn’t see it anywhere :/

PS: I think the Accordion element would fix pretty much all the issues (and reduce the update complexity of this page) if only it had the possibility of having more than one column. Are you thinking of adding that feature in a near future?

[arminunruh]

I understand the row ID process method, but maybe, for lack of a better one in this context, it would be more user-friendly to automatically remove the Expand/Collapse links on synced elements (of the later added layout). That way, it wouldn’t create subsequent issues on the first layout, and we would still be able to keep the text synced between layouts (we would just need to add the expand/collapse links manually on each layout).

yea but if you first create a custom phone layout, i think the row Ids are the same, so i think we dont need this.

Meaning if you would: delete your custom phone layout, create a new one where it copies over the layout,
then the expand collapse should work the same way in the custom phone layout

Also, where’s that “Not syncing text” warning? I didn’t see it anywhere :/

When you click Ok after editing a text element that contains a expand/collapse link

Since all the desktop and mobile layouts have synced elements (with “Sync Element Content”), when I change the Expand/Collapse Row Links on mobile, it creates issues on desktop and vice versa. So it’s basically creating problems that the user doesn’t expect and can miss.

No, this should show the “Not syncing text” warning and then it should not sync this text

[dafv]

Thank you @arminunruh

I didn’t know that we could delete the phone layout and create a new one.
I tried that and it fixed the issue!

Regarding the “Not syncing text” warning, it never appeared for me and I believe I figured out why.

That warning only appears when a text element is created in one layout, then added to the other layout with the sync option, and only after that the text is edited with an Expand/Collapse Link.

But when the text element is created in one layout, edited with an Expand/Collapse Link first, and only after that added to the other layout (with the sync option), the warning doesn’t show up and the links get synced between both layouts.

Also, even with the first method, the warning doesn't show up when the Expand/Collapse Link is inside a Table Element.

I think these are the reasons why the issue happened in my case, unfortunately.
Do you think it would be possible to make these behaviors more consistent by default?

[arminunruh]

Hm you are right, this only works for text elements, not for any other elements that can contain texts like accordions, table etc.

But when the text element is created in one layout, edited with an Expand/Collapse Link first, and only after that added to the other layout (with the sync option), the warning doesn’t show up and the links get synced between both layouts.

True. You mean you create a text element. Then click "Insert into Phone Layout".
Then it just copies over the text mmh

[arminunruh]

those things should be fixed with the next update im releasing today